chore: adding edit service descriptor #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patriknw
reviewed
Jan 13, 2025
| Akka services can also be described and managed with *YAML service descriptors*. | ||
| Akka services can also be described and managed with *YAML service descriptors*. See xref:reference:descriptors/service-descriptor.adoc[]. | ||
|
|
||
| Once you have <<_deploying_a_service, deployed your service>>, you can modify it by editing its service descriptor: |
There was a problem hiding this comment.
I think we should move this to a separate === section, after "Redeploying with a descriptor".
Edit would be a very rare operation in my opinion, unless possibly when toying around. Instead, the normal cycle is to edit the descriptor in git, then apply it again.
There was a problem hiding this comment.
OK. Let's do that.
There was a problem hiding this comment.
done, now.
- creating section to edit descriptor in place
franciscolopezsancho
requested review from
patriknw
and removed request for
octonato
patriknw
approved these changes
Jan 16, 2025
franciscolopezsancho
deleted the
chore_docs_add_edit_service_descriptor
branch
Merged
aludwiko
pushed a commit
that referenced
this pull request
Jan 17, 2025
* chore: adding edit service descriptor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was no mention in the section to edit the service.
Also a bit of rewording.