feat: add query param on http RequestBuilder (#157)

akka-javasdk/src/main/java/akka/javasdk/http/RequestBuilder.java

@@ -36,6 +36,8 @@ public interface RequestBuilder<R> {
 
   RequestBuilder<R> withTimeout(Duration timeout);
 
+  RequestBuilder<R> addQueryParameter(String key, String value);
+
   /**
    * Transform the request before sending it. This method allows for extra request configuration.
    */

akka-javasdk/src/main/scala/akka/javasdk/impl/http/HttpClientImpl.scala

@@ -192,4 +192,10 @@ private[akka] final case class RequestBuilderImpl[R](
       timeout,
       request,
       (res: HttpResponse, bytes: ByteString) => new StrictResponse[T](res, parse.apply(bytes.toArray)))
+
+  override def addQueryParameter(key: String, value: String): RequestBuilder[R] = {
+    val query = request.getUri.query().withParam(key, value)
+    val uriWithQuery = request.getUri.query(query)
+    withRequest(request.withUri(uriWithQuery))
+  }
 }

akka-javasdk/src/test/scala/akka/javasdk/impl/http/HttpClientImplSpec.scala

@@ -0,0 +1,48 @@
+/*
+ * Copyright (C) 2021-2024 Lightbend Inc. <https://www.lightbend.com>
+ */
+
+package akka.javasdk.impl.http
+
+import akka.actor.typed.ActorSystem
+import akka.actor.typed.scaladsl.Behaviors
+import akka.http.javadsl.model.HttpHeader
+import akka.javasdk.http.RequestBuilder
+import akka.util.ByteString
+import org.scalatest.matchers.should.Matchers
+import org.scalatest.wordspec.AnyWordSpec
+
+class HttpClientImplSpec extends AnyWordSpec with Matchers {
+  val system: ActorSystem[Nothing] = ActorSystem[Nothing](Behaviors.empty[Nothing], "httpClient")
+
+  "RequestBuilderImpl" should {
+    "add query parameter" in new HttpClientImplSuite {
+      val builder: RequestBuilderImpl[ByteString] = get { builder =>
+        builder
+          .addQueryParameter("key", "some value")
+          .addQueryParameter("another", "name")
+      }
+      builder.request.getUri.toString shouldBe "http://test.com/test?key=some+value&another=name"
+    }
+  }
+
+}
+
+trait HttpClientImplSuite {
+  implicit private val system: ActorSystem[Nothing] =
+    ActorSystem[Nothing](Behaviors.empty[Nothing], "RequestBuilderImplSpec")
+
+  val baseUrl = "http://test.com"
+  val path = "/test"
+  val headers: Seq[HttpHeader] = Seq.empty
+
+  private def client = new HttpClientImpl(system, baseUrl, headers)
+
+  private def get(url: String)(
+      builder: RequestBuilder[ByteString] => RequestBuilder[ByteString]): RequestBuilderImpl[ByteString] = {
+    builder(client.GET(url))
+      .asInstanceOf[RequestBuilderImpl[ByteString]]
+  }
+  def get(builder: RequestBuilder[ByteString] => RequestBuilder[ByteString]): RequestBuilderImpl[ByteString] =
+    get(path)(builder)
+}