Skip to content

Commit

Permalink
exclude -> disable
Browse files Browse the repository at this point in the history
  • Loading branch information
aludwiko committed Jan 9, 2025
1 parent 1b4f16a commit 3bdeb7d
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion akka-javasdk-tests/src/test/resources/application.conf
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
# Using a different port to not conflict with parallel tests
akka.javasdk.testkit.http-port = 39391
akka.javasdk.components.exclude = "akkajavasdk.components.keyvalueentities.user.ProdCounterEntity,akkajavasdk.components.keyvalueentities.user.StageCounterEntity"
akka.javasdk.components.disabled = "akkajavasdk.components.keyvalueentities.user.ProdCounterEntity,akkajavasdk.components.keyvalueentities.user.StageCounterEntity"
4 changes: 2 additions & 2 deletions akka-javasdk/src/main/resources/reference.conf
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,6 @@ akka.javasdk {
collector-endpoint = ${?COLLECTOR_ENDPOINT}
}
}
# The comma separated list of FQCNs of components to exclude from running
components.exclude = ""
# The comma separated list of FQCNs of components disabled from running
components.disable = ""
}
4 changes: 2 additions & 2 deletions akka-javasdk/src/main/scala/akka/javasdk/impl/SdkRunner.scala
Original file line number Diff line number Diff line change
Expand Up @@ -357,8 +357,8 @@ private final class Sdk(

private def isExcluded(clz: Class[_]): Boolean = {
val componentName = clz.getName
if (sdkSettings.excludedComponents.contains(componentName)) {
logger.info("Ignoring component [{}] as it is excluded in the configuration", clz.getName)
if (sdkSettings.disabledComponents.contains(componentName)) {
logger.info("Ignoring component [{}] as it is disabled in the configuration", clz.getName)
true
} else {
false
Expand Down
4 changes: 2 additions & 2 deletions akka-javasdk/src/main/scala/akka/javasdk/impl/Settings.scala
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ private[impl] object Settings {
DevModeSettings(
serviceName = sdkConfig.getString("dev-mode.service-name"),
httpPort = sdkConfig.getInt("dev-mode.http-port"))),
excludedComponents = sdkConfig.getString("components.exclude").split(",").map(_.trim).toSet)
disabledComponents = sdkConfig.getString("components.disable").split(",").map(_.trim).toSet)
}

final case class DevModeSettings(serviceName: String, httpPort: Int)
Expand All @@ -38,4 +38,4 @@ private[impl] final case class Settings(
cleanupDeletedEventSourcedEntityAfter: Duration,
cleanupDeletedKeyValueEntityAfter: Duration,
devModeSettings: Option[DevModeSettings],
excludedComponents: Set[String])
disabledComponents: Set[String])

0 comments on commit 3bdeb7d

Please sign in to comment.