fix(r2dbc): Leak of in-flight offsets #1300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
patriknw
commented
Jan 17, 2025
patriknw
commented
- concurrency issue in R2dbcOffsetStore when saving offsets in case of concurrent modifications
- map vs flatMap
- DynamoDB was correct
- added some more logging
* concurrency issue in R2dbcOffsetStore when saving offsets in case of concurrent modifications * map vs flatMap * DynamoDB was correct * added some more logging
patriknw
commented
Jan 17, 2025
| @@ -630,15 +652,19 @@ private[projection] class R2dbcOffsetStore( | |||
|
|
|||
| val offsetInserts = dao.insertTimestampOffsetInTx(conn, filteredRecords) | |||
|
|
|||
| offsetInserts.map { _ => | |||
| offsetInserts.flatMap { _ => | |||
There was a problem hiding this comment.
This was the bug. I think it was introduced in a recent version when the lazy loading of offsets was added.
| @@ -656,8 +682,9 @@ private[projection] class R2dbcOffsetStore( | |||
| } | |||
| if (newInflight.size >= 10000) { | |||
There was a problem hiding this comment.
I have also tested this in a real service where I logged the inFlight size and could see that it was increasing over time. After the fix it is 0 after each save offsets, as expected.
johanandren
approved these changes
Jan 17, 2025
pvlugter
approved these changes
Jan 18, 2025
| @@ -630,15 +652,19 @@ private[projection] class R2dbcOffsetStore( | |||
|
|
|||
| val offsetInserts = dao.insertTimestampOffsetInTx(conn, filteredRecords) | |||
|
|
|||
| offsetInserts.map { _ => | |||
| offsetInserts.flatMap { _ => | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.