fix(dynamodb): avoid unnecessary rejection given expired offsets #1295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patriknw
approved these changes
Jan 14, 2025
| @@ -155,10 +151,6 @@ import software.amazon.awssdk.services.dynamodb.model.BatchWriteItemResponse | |||
| } | |||
| attributes.put(Seen, AttributeValue.fromM(seen)) | |||
|
|
|||
| expiry.foreach { timestamp => | |||
| attributes.put(Expiry, AttributeValue.fromN(timestamp.getEpochSecond.toString)) | |||
| } | |||
There was a problem hiding this comment.
When looking at this, noticed the expiry set on the separate latest-by-slice offsets. To keep things safer, have removed this expiry, so we always keep this for restarting a projection, while the per-pid offsets will be expired.
Makes sense. It's the per-pid that will grow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar changes as #1293 for DynamoDB, but using TTL expiry.
While for R2DBC, we're managing the offset deletion, and basing this on the event timestamps, for DynamoDB it's just a simple TTL expiry set when the offset is written. So we use an accept before time that's just based on now minus the expiry.
When looking at this, noticed the expiry set on the separate latest-by-slice offsets. To keep things safer, have removed this expiry, so we always keep this for restarting a projection, while the per-pid offsets will be expired.