test: extend R2DBC EventSourcedEndToEndSpec #1292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patriknw
reviewed
Jan 10, 2025
| Thread.sleep(500) | ||
| // resume projections again | ||
| if (n == (numberOfEvents / 2) + 20) | ||
| startProjectionsFactory() |
There was a problem hiding this comment.
I changed to var projections recently. This would be projections = startProjectionsFactory().
The reason is that later we are stopping the projections, but that is not these new projections.
There was a problem hiding this comment.
Ah, missed that when aligning with the dynamodb test. I'll fix both.
| startParams, | ||
| (projectionId, sourceProvider) => | ||
| R2dbcProjection | ||
| .atLeastOnce( |
There was a problem hiding this comment.
we also have some async variants, worth adding all?
atLeastOnceAsync
groupedWithinAsync
There was a problem hiding this comment.
Wasn't sure, but may as well cover all the variants now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend the r2dbc EventSourcedEndToEndSpec to other projection types, following #1282 for DynamoDB.