fix: Timestamp validation of previous seqNr #1246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patriknw
commented
Nov 15, 2024
|
|
||
| // starting with 2 projections, testing 512-1023 | ||
| offsetStore1.saveOffset(OffsetPidSeqNr(TimestampOffset(time(2), Map(p1 -> 1L)), p1, 1L)).futureValue | ||
| offsetStore1.saveOffset(OffsetPidSeqNr(TimestampOffset(time(100), Map(p3 -> 1L)), p3, 1L)).futureValue |
There was a problem hiding this comment.
My hypothesis is that the lower scale 512-1023 projection deleted some offsets from 512-767 slices. Then when that higher scale projection 512-767 is starting it is trying the timestamp of previous validation but that falls within the time window of that projection and is therefore rejected.
patriknw
force-pushed
the
wip-timestamp-validation-patriknw
branch
from
811ec40 to
bb9d82b
Compare
* base the validaiton time window for the previous sequence number on start timestamp and backtracking window
patriknw
force-pushed
the
wip-timestamp-validation-patriknw
branch
from
bb9d82b to
fa3ecfc
Compare
Co-authored-by: Peter Vlugter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on start timestamp and backtracking window