Skip to content

Commit

Permalink
review feedback addressed
Browse files Browse the repository at this point in the history
  • Loading branch information
johanandren committed Dec 14, 2023
1 parent d6704cd commit 5807f71
Show file tree
Hide file tree
Showing 6 changed files with 20 additions and 16 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -85,9 +85,9 @@ Java

### Serialization

The state and events of the entity must be serializable because they are written to the datastore, if the local drone control needs to scale out across several nodes to handle traffic, the commands would also be sent between nodes within the Akka cluster. The sample project includes built-in CBOR serialization using the @extref[Akka Serialization Jackson module](akka:serialization-jackson.html). This section describes how serialization is implemented. You do not need to do anything specific to take advantage of CBOR, but this section explains how it is included.
The state and events of the entity must be serializable because they are written to the datastore, if the local drone control needs to scale out across several nodes to handle traffic, the commands would also be sent between nodes within the Akka cluster.

The state, commands and events are marked as `akka.serialization.jackson.CborSerializable` which is configured to use the built-in CBOR serialization.
The state, commands and events are marked with `akka.serialization.jackson.CborSerializable` to use CBOR serialization from @extref[Akka Serialization Jackson module](akka:serialization-jackson.html) for serialization.

### Journal storage

Expand Down Expand Up @@ -173,8 +173,8 @@ Java

The complete sample can be downloaded from GitHub, but note that it also includes the next steps of the guide:

* Java: https://github.com/akka/akka-projection/tree/main/samples/grpc/local-drone-control-service-java
* Scala: https://github.com/akka/akka-projection/tree/main/samples/grpc/local-drone-control-service-scala
* local-drone-control-service Scala: [local-drone-control-service.zip](../attachments/local-drone-control-service-scala.zip)
* local-drone-control-service Java: [local-drone-control-service.zip](../attachments/local-drone-control-service-java.zip)

@@@ div { .group-scala }

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -240,8 +240,8 @@ Java

The complete sample can be downloaded from GitHub, but note that it also includes the next steps of the guide:

* Java: https://github.com/akka/akka-projection/tree/main/samples/grpc/restaurant-drone-deliveries-service-java
* Scala: https://github.com/akka/akka-projection/tree/main/samples/grpc/restaurant-drone-deliveries-service-scala
* restaurant-drone-deliveries-service Scala: [restaurant-drone-deliveries-service.zip](../attachments/restaurant-drone-deliveries-service-scala.zip)
* restaurant-drone-deliveries-service Java: [restaurant-drone-deliveries-service.zip](../attachments/restaurant-drone-deliveries-service-java.zip)

As this service consumes events from the service built in the previous step, start the local-drone-control service first:

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,8 @@ Java

The complete sample can be downloaded from GitHub, but note that it also includes the next step of the guide:

* Java: https://github.com/akka/akka-projection/tree/main/samples/grpc/restaurant-drone-deliveries-service-java
* Scala: https://github.com/akka/akka-projection/tree/main/samples/grpc/restaurant-drone-deliveries-service-scala
* restaurant-drone-deliveries-service Scala: [restaurant-drone-deliveries-service.zip](../attachments/restaurant-drone-deliveries-service-scala.zip)
* restaurant-drone-deliveries-service Java: [restaurant-drone-deliveries-service.zip](../attachments/restaurant-drone-deliveries-service-java.zip)

In this step we created a local entity, so we can try it out by running the restaurant-drone-deliveries-service without
any local-drone-control services.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -163,8 +163,10 @@ Java

The complete sample can be downloaded from GitHub, but note that it also includes the next steps of the guide:

* Java: https://github.com/akka/akka-projection/tree/main/samples/grpc/restaurant-drone-deliveries-service-java
* Scala: https://github.com/akka/akka-projection/tree/main/samples/grpc/restaurant-drone-deliveries-service-scala
* restaurant-drone-deliveries-service Scala: [restaurant-drone-deliveries-service.zip](../attachments/restaurant-drone-deliveries-service-scala.zip)
* local-drone-control-service Scala: [local-drone-control-service.zip](../attachments/local-drone-control-service-scala.zip)
* restaurant-drone-deliveries-service Java: [restaurant-drone-deliveries-service.zip](../attachments/restaurant-drone-deliveries-service-java.zip)
* local-drone-control-service Java: [local-drone-control-service.zip](../attachments/local-drone-control-service-java.zip)

As this service consumes events from the service built in the previous step, start the local-drone-control service first:

Expand Down
6 changes: 4 additions & 2 deletions akka-edge-docs/src/main/paradox/guide/5-charging-station.md
Original file line number Diff line number Diff line change
Expand Up @@ -168,8 +168,10 @@ Java

The complete sample can be downloaded from GitHub, but note that it also includes the next steps of the guide:

* Java: https://github.com/akka/akka-projection/tree/main/samples/grpc/restaurant-drone-deliveries-service-java
* Scala: https://github.com/akka/akka-projection/tree/main/samples/grpc/restaurant-drone-deliveries-service-scala
* restaurant-drone-deliveries-service Scala: [restaurant-drone-deliveries-service.zip](../attachments/restaurant-drone-deliveries-service-scala.zip)
* local-drone-control-service Scala: [local-drone-control-service.zip](../attachments/local-drone-control-service-scala.zip)
* restaurant-drone-deliveries-service Java: [restaurant-drone-deliveries-service.zip](../attachments/restaurant-drone-deliveries-service-java.zip)
* local-drone-control-service Java: [local-drone-control-service.zip](../attachments/local-drone-control-service-java.zip)

As this service consumes events from the service built in the previous step, start the local-drone-control service first:

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -116,8 +116,8 @@ We are now going to deploy the `restaurant-drone-deliveries-service` to the crea

This step is for deploying:

* Java: https://github.com/akka/akka-projection/tree/main/samples/grpc/restaurant-drone-deliveries-service-java
* Scala: https://github.com/akka/akka-projection/tree/main/samples/grpc/restaurant-drone-deliveries-service-scala
* restaurant-drone-deliveries-service Scala: [restaurant-drone-deliveries-service.zip](../attachments/restaurant-drone-deliveries-service-scala.zip)
* restaurant-drone-deliveries-service Java: [restaurant-drone-deliveries-service.zip](../attachments/restaurant-drone-deliveries-service-java.zip)

Build and publish the docker image to docker.io:

Expand Down Expand Up @@ -216,8 +216,8 @@ kubectl get services

This step is for deploying:

* Java: https://github.com/akka/akka-projection/tree/main/samples/grpc/local-drone-control-java
* Scala: https://github.com/akka/akka-projection/tree/main/samples/grpc/local-drone-control-scala
* local-drone-control-service Scala: [local-drone-control-service.zip](../attachments/local-drone-control-service-scala.zip)
* local-drone-control-service Java: [local-drone-control-service.zip](../attachments/local-drone-control-service-java.zip)

### Local Drone Control Namespace

Expand Down

0 comments on commit 5807f71

Please sign in to comment.