Fail with unwrapped exception when using CompletionStage #2054 #2205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refs: akka#2054 Unwraps the original exception that caused the `CompletionStage` to fail. This original exception can then be used on the custom `ExceptionHandler`.
akka-ci
added
validating
|
Test PASSed. |
|
Travis failure is because 10.1.5 artifacts are not yet in Maven Central |
jrudolph
approved these changes
Sep 6, 2018
| D.complete(value.asScala.fast.map(v ⇒ ToResponseMarshallable(v)(marshaller)).recover(unwrapCompletionException)) | ||
| } | ||
|
|
||
| // TODO: This might need to be raised as an issue to scala-java8-compat instead. |
There was a problem hiding this comment.
👍 Can you file an issue there as well?
There was a problem hiding this comment.
I will check if it already exists, or will do otherwise
There was a problem hiding this comment.
johanandren
approved these changes
Sep 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #2054
Unwraps the original exception that caused the
CompletionStageto fail.This original exception can then be used on the custom
ExceptionHandler.Please note that the unwrapping is only done for the methods that take a
CompletionStagenot for the ones getting a ScalaFuture.