removed redundant checks for password inputs

akirk · Jul 8, 2010 · 235f7cd · 235f7cd
1 parent ecc9b9d
commit 235f7cd
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/demo.html b/demo.html
@@ -6,7 +6,7 @@
     <script src="jquery.placeholder.js"></script>
     <title>jQuery-Placeholder</title>
     <style>
-    input {padding:4px; width:200px;}
+    input {padding:4px; width:225px;}
     </style>
 </head>
 <body>

diff --git a/jquery.placeholder.js b/jquery.placeholder.js
@@ -9,20 +9,21 @@
         // Special treatment for password inputs
         if (input.attr('type') == 'password') {
             input.attr('realType', 'password');
+            this.isPassword = true;
         }
         this.input = input;
         // IE doesn't allow changing the type of password inputs
         this.fakePassword = $("<input>").val(input.attr('placeholder')).focus(function() {
             input.trigger("focus")
             $(this).hide();
-        }).css({width : input.width()});
+        });
     }
     Placeholder.prototype = {
         show : function(loading) {
             // FF and IE saves values when you refresh the page. If the user refreshes the page with 
             // the placeholders showing they will be the default values and the input fields won't be empty.
             if (this.input[0].value == '' || (loading && this.valueIsPlaceholder())) {
-                if (this.isPassword()) {
+                if (this.isPassword) {
                     try { // IE doesn't allow us to change the input type
                         this.input[0].setAttribute('type', 'input');
                     } catch (e) {
@@ -35,7 +36,7 @@
         },
         hide : function() {
             if (this.valueIsPlaceholder() && this.input.hasClass('placeholder')) {
-                if (this.isPassword()) {
+                if (this.isPassword) {
                     try {
                         this.input[0].setAttribute('type', 'password');
                     } catch (e) { }
@@ -47,9 +48,6 @@
                 this.input.removeClass('placeholder');
             }
         },
-        isPassword: function() {
-            return this.input.attr('realType') == 'password';
-        },
         valueIsPlaceholder : function() {
             return this.input[0].value == this.input.attr('placeholder');
         }