Repository navigation
docs: fix the complexity claim on Database::remove - #1344
Merged
ajeetdsouza merged 2 commits intoOct 23, 2026
Merged
Conversation
The doc comment promised O(1), but remove() first locates the entry with position() over all dirs, which is O(n); only the swap_remove that follows is O(1).
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Database::removeis documented as O(1):The lookup is a linear scan over every entry (
iter().position(..)), so the call is O(n); only the subsequentswap_removeis O(1) — which is also what "does not preserve ordering" refers to. Reworded the doc comment to state both costs. No behaviour change.Tested:
cargo check --all-targetspasses on this branch (exit 0);rustfmt --checkreports no diff forsrc/db/mod.rs(the crate's nightly-onlywrap_commentsoption is ignored by stable rustfmt, so the comment reflow stays within the existing 100-column style).