Skip to content

add value source location property#621

Closed
RafeArnold wants to merge 3 commits intoajalt:masterfrom
RafeArnold:value-source-location-property
Closed

add value source location property#621
RafeArnold wants to merge 3 commits intoajalt:masterfrom
RafeArnold:value-source-location-property

Conversation

@RafeArnold
Copy link
Contributor

allowing more useful help messages upon transform failure.

implementation of #619

  • add location property to ValueSource.Invocation
  • add location to MapValueSource invocations.
  • add location to JsonValueSource invocations.

@RafeArnold
Copy link
Contributor Author

i think the ability to construct the location string lazily would be useful, as it's only used for the unhappy path of parsing and could potentially require more complex computation for some value sources. i havent implemented this functionality here because it would require OptionInvocation and OptionCallTransformContext to also allow lazy name properties which may have backwards compatibility concerns. i can have a crack at that additional work if it would be useful.

allowing more useful help messages upon transform failure.
to demonstrate more complex invocation locations.
@ajalt
Copy link
Owner

ajalt commented Jan 16, 2026

Closing in favor of #631

@ajalt ajalt closed this Jan 16, 2026
ajalt added a commit that referenced this pull request Jan 16, 2026
Fixes #619 
Replaces #621, this adds a commit to help binary compatibility.

---------

Co-authored-by: rafearnold <rafe.arnold@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants