Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update: Storage information for Thanos to include tiered storage #641

Merged
merged 6 commits into from
Jan 21, 2025
Merged

update: Storage information for Thanos to include tiered storage #641

merged 6 commits into from
Jan 21, 2025
+53 −18

Conversation

harshini-rangaswamy
Copy link
Contributor

@harshini-rangaswamy harshini-rangaswamy commented Jan 15, 2025 •
edited
Loading

Describe your changes

Update Thanos tiered storage docs to clarify mandatory usage, align with other offerings, and include cost details.

MA-3185

Preview: https://harshini-metrics-storage-upd.aiven-docs.pages.dev/docs/products/metrics/concepts/storage-resource-scaling

Checklist

  • The first paragraph of the page is on one line.
  • The other lines have a line break at 90 characters.
  • I checked the output.
  • I applied the style guide.
  • My links start with /docs/.

@harshini-rangaswamy harshini-rangaswamy changed the title udpate: Storage information for Thanos to include tiered storage update: Storage information for Thanos to include tiered storage Jan 15, 2025
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Jan 15, 2025 •
edited
Loading

Deploying aiven-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 31c8b16
Status: ✅  Deploy successful!
Preview URL: https://acc6dd06.aiven-docs.pages.dev
Branch Preview URL: https://harshini-metrics-storage-upd.aiven-docs.pages.dev

View logs

@harshini-rangaswamy harshini-rangaswamy self-assigned this Jan 15, 2025
@harshini-rangaswamy harshini-rangaswamy marked this pull request as ready for review January 21, 2025 11:56
@harshini-rangaswamy harshini-rangaswamy requested a review from a team as a code owner January 21, 2025 11:56
@harshini-rangaswamy harshini-rangaswamy added review/SME An SME must review the PR. and removed review/SME An SME must review the PR. labels Jan 21, 2025
staceysalamon-aiven
staceysalamon-aiven approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@staceysalamon-aiven staceysalamon-aiven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I added a couple of small suggestions, but this is all nice and clear.

docs/products/metrics/concepts/storage-resource-scaling.md Outdated Show resolved Hide resolved
docs/products/metrics/concepts/storage-resource-scaling.md Outdated Show resolved Hide resolved
docs/products/metrics/concepts/storage-resource-scaling.md Outdated Show resolved Hide resolved
@harshini-rangaswamy harshini-rangaswamy merged commit 661fdc3 into main Jan 21, 2025
4 checks passed
@harshini-rangaswamy harshini-rangaswamy deleted the harshini-metrics-storage-updates branch January 21, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cincinnat cincinnat cincinnat approved these changes

@staceysalamon-aiven staceysalamon-aiven staceysalamon-aiven approved these changes

@hoang-vo hoang-vo Awaiting requested review from hoang-vo

Assignees

@harshini-rangaswamy harshini-rangaswamy

Labels
review/SME An SME must review the PR. service/thanos-metrics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@harshini-rangaswamy @cincinnat @staceysalamon-aiven