fix: rely on JuliaSyntax's tokenize instead of regex-based splitting of strings during conversion to expr #36
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35
This attempts to (sustainably) fix the error that occurred due to the regex-based splitting of strings during "to expression" conversion. It now properly tokenizes strings. However, that also revealed that column names like
08_pv@data
are ambigous, since that would be valid Julia syntax for8 * _pv@data
. If this is detected the model building is aborted (since we don't know what a user actually means).The MWE from #35 is now included as test case, and a base set of reasonable unit tests has been added.
This pull request includes updates to various example configuration files to ensure compatibility with version 2.0.3 of the core library. Additionally, it updates the references to data columns in several examples to reflect new naming conventions.
Data column reference updates:
availability_factor
andvalue
references insrc/assets/examples/07_csv_filestorage.iesopt.yaml
to use the new naming convention. [1] [2]availability_factor
andvalue
references insrc/assets/examples/08_basic_investment.iesopt.yaml
to use the new naming convention. [1] [2]availability_factor
andvalue
references insrc/assets/examples/10_basic_load_shedding.iesopt.yaml
to use the new naming convention. [1] [2]conversion
andvalue
references insrc/assets/examples/15_varying_efficiency.iesopt.yaml
to use the new naming convention. [1] [2]capacity
reference insrc/assets/examples/17_varying_connection_capacity.iesopt.yaml
to use the new naming convention.