Fix fan speed for T2 MacBooks #1
Conversation
|
I also aligned the descriptions/labels left and values on the right. Personal preference which is better, but I think it's easier to read. Also since it's sorted from highest temp to lowest, the most important information is easily readable (because it's first, and on the far right) Demo: Currently I hardcoded the menu width to Maybe apply text styles in a separate loop after creating the labels, and just use the |
|
@mrousavy Great job! But I'm a little busy these days, I'll review it this weekend, sorry! |
MySensors/AppDelegate.swift
Outdated
| for item in data.items { | ||
| let m = NSMenuItem() | ||
| m.title = "\(item.0) \(item.1)" | ||
|
|
There was a problem hiding this comment.
Looks like some of the lines which you committed is indent by tab, I think we should using space instead. Otherwise the codes looks wired like in this PR now.
There was a problem hiding this comment.
You can configure your XCode to using four space as you tap the tab key.
README.md
Outdated
| @@ -21,3 +40,4 @@ MIT lisence with exceptions: | |||
| - The app icon is designed by [nervouna](https://github.com/nervouna) under MIT license. | |||
| - The menu bar icon is copied from Google's Material Design under Apache 2.0 license. | |||
| - The SMC.swift is copied from [SMCKit project](https://github.com/beltex/SMCKit) under [MIT license](https://github.com/beltex/SMCKit/blob/master/LICENSE). | |||
| - Forked and adjusted by [mrousavy](https://github.com/mrousavy) | |||
There was a problem hiding this comment.
Hi I'd like to add any contributors name in the README file, but this section is for the codes (or assets) which is copied from other project's LICENSE, so I think this change here is not suitable.
I think we can add another section to show contributor's name.
And I have another project, is using a service to the contributor's name like this: https://github.com/aisk/rust-memcache/blob/master/README.md#contributors , I think you can take a look it's source code and copy it here.
MySensors/SMC.swift
Outdated
| @@ -6,6 +6,9 @@ | |||
| // | |||
| // Copyright (C) 2014-2017 beltex <https://beltex.github.io> | |||
| // | |||
| // Updated to work with T2 MacBooks using code from | |||
There was a problem hiding this comment.
These three lines shoule put below next section.
|
Hi @mrousavy I like you changes but I think there are some minor changes need to resolve which I have commented. Greet job, many thanks! |
|
Oh, my bad! Didn't notice Xcode wasn't using spaces, should've double checked that. Also, the README changes shouldn't be in here as well, will remove them right away. |
|
LGTM, I'll try to test the changes on my machine, wait a minutes. |
|
Looks like the fan speed does not worked my my machine (MacBook Pro Mid 2015, no T2 chips):
|
|
Hmm that's weird, maybe we should check for device type and then decide between the methods to use fan speed, legacy on non T2 chips and the new one on T2 chips.. |
|
Good idea, I'll have a try tomorrow. |
|
@mrousavy Hi readly sorry for the late of reply. I just took a look at the original PR from SMCKit, and found they have a I copied the change and it works fine. I think in this PR. we can copy the total |
On newer MacBooks (T2 chips) the fan info was throwing an error. Also, I've put the temps in the front and sorted by them.