Repin vllm and inspect_evals so the Dockerfile builds#36
Open
surelyMersad wants to merge 1 commit into
Open
Conversation
Two upstream-shifted dependencies were preventing the harbor_adapter Dockerfile from building on Modal: - vllm==0.11.0 requires xformers==0.0.32.post1, which is no longer on PyPI for manylinux_x86_64. Repinned to 0.19.1, which builds and runs end-to-end on Modal. - inspect_evals was cloned --depth=1 from main, but main HEAD now requires Python>=3.11 while the image installs python3.10. Switched to `uv pip install "inspect_evals @ git+...@<sha>"` pinned to commit 03cb4bc2 (2026-03-15), the last commit on main still declaring requires-python = ">=3.10". Also removes the manual git clone step. Also adds local-only artifacts to .gitignore so they don't sneak in.
4 tasks
Collaborator
|
Thanks for catching the build break, but we can't take the vllm bump as-is. We used vllm 0.11.0 for the original PTB leaderboard runs, and any inference version change risks decoding level divergence from those baselines, which is a parity claim we need to defend in the paper. Same logic for the rest of the ML stack. Already pushed an alternate fix to
Builds on Modal end to end. Thus the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two upstream-shifted dependencies were preventing the harbor_adapter Dockerfile from building on Modal:
vllm==0.11.0 requires xformers==0.0.32.post1, which is no longer on PyPI for manylinux_x86_64. Repinned to 0.19.1, which builds and runs end-to-end on Modal.
inspect_evals was cloned --depth=1 from main, but main HEAD now requires Python>=3.11 while the image installs python3.10. Switched to
uv pip install "inspect_evals @ git+...@<sha>"pinned to commit 03cb4bc2 (2026-03-15), the last commit on main still declaring requires-python = ">=3.10". Also removes the manual git clone step.Also adds local-only artifacts to .gitignore so they don't sneak in.
Test plan
python run_adapter.py --benchmark gsm8k --model qwen3-1.7b --output ./tasksgenerates withouterror
harbor run -c <task>/job.yaml --agent nop --env modal --yesbuilds the image successfully onModal — verified twice in this branch (~8 min build with warm cache, ~15 min cold), no resolver errors
on either the
vllmorinspect_evalsinstall steps. Verifier writesreward.txtandmetrics.jsoncleanly.