fix: preserve firefoxId from dynamically detected extensions#942
fix: preserve firefoxId from dynamically detected extensions#942austingray wants to merge 1 commit intoairgap-it:masterfrom
Conversation
b734cef to
c37fac8
Compare
|
Thanks for the PR! We've actually already partially addressed this in our 5.0.0-beta branch - the UI layer already has firefoxId support for wallets in our static list. However, you're right that we're missing the dynamic discovery piece (capturing firefoxId from the pong response in PostMessageTransport). We'll review your implementation and adopt the missing parts. In the meantime, to get your wallet listed officially, please open a PR to our wallet registry: https://github.com/airgap-it/beacon-wallet-list Is your extension already released? We'd be happy to test it if you can share a link or point us to where we can install it. |
|
Hey, awesome news. My wallet isn't ready to be released and my number one priority is supporting firefox since there are no tezos firefox browser wallet extensions available. It's open-source and available for review here https://github.com/austingray/tm-wallet. Once I get it to a more publishable state I will most certainly be opening a PR for it to be added to the registry. Thank you so much. |
a75d80c to
16643a8
Compare
|
did some cleanup and removed some hacking about with icons i was doing |
16643a8 to
2d4b37d
Compare
Summary
This PR fixes Firefox extension detection for dynamically detected wallet extensions by properly preserving the
firefoxIdproperty throughout the SDK.The Problem:
When a browser extension responds to the SDK's ping message with a
firefoxIdin the sender object (indicating it's a Firefox extension), the SDK was not preserving this property. This caused the "Use Extension" button to fail on Firefox because the SDK couldn't identify the extension properly.Changes:
firefoxIdoptional property to theExtensioninterfacefirefoxIdfrom pong responses inlistenForExtensions()mergeWallets()to use explicitfirefoxIdproperty from detected extensionsfirefoxIdfor dynamically detected extensionssetInstallState()to show install screen for extension-only walletsTest plan
firefoxIdin pong responsefirefoxIdcontinue to work