[GroupBy] Add spark conf flag to resolve ChrononRunDs from queryRange - #1113
Open
yogeshpv wants to merge 2 commits into
Open
[GroupBy] Add spark conf flag to resolve ChrononRunDs from queryRange#1113yogeshpv wants to merge 2 commits into
yogeshpv wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add opt-in Spark conf flag to resolve
ChrononRunDsmacro fromqueryRangeinstead ofintersectedRangein GroupBy source query rendering.Why / Goal
Currently, the
ChrononRunDsmacro inrenderDataSourceQueryis resolved usingintersectedRange.start, which requires the intersected range to be defined and single-day. This works for most cases but is limiting when callers need the macro to reflect thequeryRangedirectly (e.g., when the query date and the scanned data range diverge).This change introduces a Spark conf flag
spark.chronon.group_by.use_query_range_for_run_ds(defaultfalse) that, when enabled, resolvesChrononRunDsfromqueryRange.start(with SQL string quotes) instead ofintersectedRange.start. The existing default behavior is fully preserved when the flag is not set.Test Plan
testChrononRunDsWithQueryRangeFlaginJoinTest.scalavalidates the flag-enabled path rendersqueryRange.startinto the querytestSourceQueryRendercontinues to cover the default (flag-off) path