Revise FlushTimer implementation, add isRoot - #48
Merged
Merged
Conversation
bachand
approved these changes
Nov 13, 2025
| } | ||
| } | ||
|
|
||
| root.retireCallback = retire // initialization order |
There was a problem hiding this comment.
What does "retire" mean? is is the same as a span "ending" or more nuanced?
Author
There was a problem hiding this comment.
It's just the process of handling ended spans: batching it for reporting is pretty much it.
|
|
||
| /// Flushes the root span, and cycles the trace id | ||
| public func flushTrace() { | ||
| idleTimer?.suspend() |
| let priorRoot = _root | ||
| traceId = Identifiers.generateTraceId() | ||
| _root = Span(name: "root", traceId: traceId, parentId: nil, retireCallback: retire) | ||
| _root = nil // will be recreated on next access |
|
|
||
| var suspended = false | ||
|
|
||
| var _flushInterval: TimeInterval |
| } | ||
|
|
||
| class TestReporter : NautilusTelemetryReporter { | ||
| func testTracerRootSpanIsRoot() { |
Comment on lines
+109
to
+114
| timer.flushInterval = 0.1 | ||
|
|
||
| XCTAssertFalse(timer.suspended) | ||
|
|
||
| wait(for: [expectation2], timeout: 1.0) | ||
| XCTAssertEqual(handlerCallCount, 2) |
Co-authored-by: Michael Bachand <bachand.michael@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After some device testing, I revised the idle timer & root span approach a bit.
flushTrace-- it will be be resumed when new span is created.isRoottoSpan@bachand
@jparise