Add nil filtering & improve macOS support - #43
Merged
Conversation
jparise
approved these changes
Oct 24, 2025
| var otlpAttributes = [OTLP.V1KeyValue]() | ||
|
|
||
| let keys = attributes.keys.sorted() | ||
| let keys = filteredAttributes.keys.sorted() |
There was a problem hiding this comment.
Given that we're only using the keys from this filtered Dictionary, I think you could also do something like this as just an expression:
let keys = compactMap { (key, value) in
if case Optional<Any>.none = value.base {
return nil
}
return key
}.sorted()
bachand
reviewed
Oct 25, 2025
| let osVersion = try XCTUnwrap(attributes["os.version"] as? String) | ||
|
|
||
| // Verify platform-specific OS name | ||
| #if os(macOS) |
There was a problem hiding this comment.
I see platform-specific tests runs from CI 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jparise
@bachand