Fix ICE username/password validation#103
Conversation
|
Good catch. Any objections @fippo? |
|
Supplement: Can you add a test for this, @mikhail-barg? |
|
Adjusting the Now how do we get MacOS to work with mdns ... |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #103 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 7 7
Lines 1236 1236
=========================================
Hits 1236 1236 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I think this is hitting a totally unrelated issue (actions/runner-images#10924). Let me look into how to disable MDNS tests on github actions ... |
|
#104 should make this pass hopefully with no more action required 🤞 |
|
Looks like the CI doesn't rebase automatically, could you do it locally please? |
|
I've synced my repo (PR source) via github interface, so the PR is updated |
|
(ready to merge but we are still pondering whether to pin the Mac CI to an older version) |
This change fixes username and password validation. Old regexes are only checking for lowercase letters, so even the default values generated by
random_string()are not being validated. This became apparent while attempting to fix this issue in aiortc.