Polish of MLP Visual #39
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CSCMe
requested changes
Aug 30, 2023
|
Still having issues with bounciness. (And parts of layers bouncing outside of their containers)
Maybe we should just keep the slanting from we observed in #21 instead of physics issues that seem to be quite persistent |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog:
added autofocus and submit on enter to LayerConfigPopup. It then made sense to change the field order in the popup, so I did.
Added node placement by node count to center graph on y one y coordinate, fixing MLP in config slope up/down when layers with <7 units are added #21 . This causes some bouncyness in the graph structure which becomes somewhat displacing in large, asymmetrical graph structures (e.g. 3-6-3-3-2-2-2-6-6-6-3-1).
I managed to reduce this problem somewhat by modifying the hierarchialRepulsion physics settings.
Comments:
This is far from optimal but it was the best combination of values I found. avoidOverlap >= 0.35 causes downwards movement, nodeDistance >140 tightens the net too much. Dampening, spring changes and stabilisation settings improve the problem slightly, but less than the current variant. Velocity changes nothing.