Applying the PEP8 style guide#92
Open
Rad-hi wants to merge 5 commits intoailia-ai:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims at making the majority of the code PEP8 compliant (where possible, and reasonable).
The detection of the non-compliance was done by using
flake8(python3 -m pip install flake8&&python3 -m flake8). It's to note that the changes were not done using an autoformatter to avoid unintentional changes.The file
setup.cfgwas added to determine the behavior offlake8where I introduced some custom behavior:max-line-length = 130(by default, it's 79): this choice was made with the idea that 80 columns screens are a thing of the past.flake8doesn't like that because the PEP8 style guide mandates that all imports happen before any function definitions/calls (thus the special case of no-compliance).too many leading '#' for block comment, this has been ignored because it would require a lot of additional refactorings to be fixed, and it does not matter much (in my opinion).