Fix RAG chat temperature handling#18
Open
ar-amk wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the open Algora bounty for
[ISAAC-497] Implement an enhanced RAG Pipeline for Scientific/Research Workflows./claim #45
Bounty reference: https://algora.io/isaac/bounties/clq18zr98000ejs0gt0nv7gwu
Summary
OpenAIStreaminstead of silently forcing every streamed answer to0.NaN, infinite, or out-of-range temperature values.Why this helps the scientific RAG workflow
Scientific and research workflows often need controlled answer variance: deterministic extraction for evidence-heavy questions, and slightly higher temperature for synthesis or exploration. The UI already collects a temperature setting, but the RAG stream ignored it. This PR makes the existing control actually affect RAG answers while preserving a safe default.
Verification
From
ui/:npx vitest run __tests__/rag-chat-options.test.ts --reporter verbose npx prettier --check pages/api/rag-chat.ts utils/server/rag-chat-options.ts __tests__/rag-chat-options.test.ts npx tsc --noEmit --pretty false npm run lint -- --file pages/api/rag-chat.ts --file utils/server/rag-chat-options.ts --file __tests__/rag-chat-options.test.ts git diff --checkResults: