Add optional resume_download argument to help download large models#130
Open
Rexhaif wants to merge 2 commits into
Open
Add optional resume_download argument to help download large models#130Rexhaif wants to merge 2 commits into
Rexhaif wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's kinda pain to download large models with unstable network connection.
For instance, i've started seeing this type of error (see screenshot). It breaks download process and you have to start again from zero bytes downloaded.
However,
cached_download(..)function in huggingface_hub hasresume_downloadargument that can be used to restart download without loosing progress. See this line. So i think it would be helpful to add it as optional argument(defaults toFalse) to theget_rudalle_model(..)so users can turn it on if they have unstable internet.