fix: handle empty message on function call cancellation#72
Open
temrjan wants to merge 2 commits intoai-forever:mainfrom
Open
fix: handle empty message on function call cancellation#72temrjan wants to merge 2 commits intoai-forever:mainfrom
temrjan wants to merge 2 commits intoai-forever:mainfrom
Conversation
The provider name input always showed "Мой E2B провайдер" regardless of selected provider type (local_docker, daytona, modal). Fixes ai-forever#68 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
When user cancels a tool call without a comment, the message field is empty/None. Previously this produced a confusing prompt like 'Прочитай его: "None"', causing the LLM to hallucinate as if the tool was executed. Now sends a clear cancellation message instructing the LLM to stop the tool call and ask the user for guidance. Fixes ai-forever#32 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a user cancels a tool call without leaving a comment, the
messagefield is empty/None. Previously this produced a prompt like:This caused the LLM to hallucinate as if the tool was actually executed.
Fix
Check if
messageis present before formatting. When empty, send a clear cancellation message:Changes
backend/giga_agent/middlewares/tool_result.py— add empty message handling inafter_modelFixes #32