Add workload support #281
Draft
Add workload support #281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kangclzjc <[email protected]>
kangclzjc
requested review from
sanjaychatterjee and
unmarshall
as code owners
Signed-off-by: kangclzjc <[email protected]>
Signed-off-by: kangclzjc <[email protected]>
Signed-off-by: kangclzjc <[email protected]>
Signed-off-by: kangclzjc <[email protected]>
Contributor
Author
|
Currently, I can generate Workload like below. These can support basic gang schedule for pcsg, pclq level. However, Workload has a limitation. For example, I defined frontend (pclq), prefill (pcsg-1), and decode (pcsg-2) in PCS. In KAI, we will place these three types into the same pod group, but in different sub-pod groups. In this case, we can ensure that these three types are scheduled together as a gang. However, in Kubernetes 1.35 Workload, sub-pod groups are not yet available—though they will be in the future. So for now, we have this limitation, but as Kubernetes versions evolve, we will be able to place them into sub-pod groups accordingly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Kubernete will support workload API to support gang schedule. We also need to support workload API not only PodGang
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #275
Special notes for your reviewer:
Does this PR introduce a API change?
Yes, we will introduce Workload API based on kubernetes/kubernetes#134564, you can check the API here(https://github.com/kubernetes/kubernetes/blob/61c629cc57649bf0ce2378903027c83939d84109/staging/src/k8s.io/api/scheduling/v1alpha1/generated.proto).
Additional documentation e.g., enhancement proposals, usage docs, etc.: