Gang Termination E2E Tests #278
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gflarity
requested review from
sanjaychatterjee and
unmarshall
as code owners
renormalize
reviewed
Nov 27, 2025
Collaborator
renormalize
left a comment
renormalize
left a comment
There was a problem hiding this comment.
Just a few nits. Thanks.
Co-authored-by: Saketh Kalaga <[email protected]> Signed-off-by: Geoff Flarity <[email protected]>
Co-authored-by: Saketh Kalaga <[email protected]> Signed-off-by: Geoff Flarity <[email protected]>
Co-authored-by: Saketh Kalaga <[email protected]> Signed-off-by: Geoff Flarity <[email protected]>
Contributor
Author
|
@renormalize take a look at e2e_gang_termination_grace_period_deadend. See the gt4-test-failure-summary.md. I didn't keep pursuing this as I wasn't sure how folks would feel about grace period in general since it wasn't passing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Tests for gang termination. These are currently failing as per this issue #277.
What this PR does / why we need it:
Proper E2E tests for gang termination.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a API change?
Additional documentation e.g., enhancement proposals, usage docs, etc.: