Skip to content

Conversation

@sanjaychatterjee
Copy link
Collaborator

No description provided.

Signed-off-by: Sanjay Chatterjee <[email protected]>
@sanjaychatterjee sanjaychatterjee marked this pull request as draft August 27, 2025 08:12
gflarity
gflarity previously approved these changes Aug 29, 2025
Copy link
Contributor

@gflarity gflarity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one nit to add some docs

@unmarshall
Copy link
Collaborator

@sanjaychatterjee we already are using golanglint-ci for static code analysis which has quite an overlap with sonarqube. What is the standard that is used in NVIDIA?
K8s uses https://github.com/kubernetes/kubernetes/blob/master/hack/golangci.yaml.in and i think this is more a less a standard tool. Have you already compared the two and do you see that using sonarqube is advantageous?

Co-authored-by: Geoff Flarity <[email protected]>
Signed-off-by: Sanjay Chatterjee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants