windows.fnl: simply sequence of remove-monitor-items + add-monitor-items -> set-monitor-items #204
+6
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ems -> set-monitor-items
Grazfather
reviewed
Jan 8, 2025
Grazfather
reviewed
Jan 9, 2025
windows.fnl
Outdated
| @@ -483,15 +472,13 @@ | |||
| Takes modal menu table-map | |||
| - Hides any previous display numbers | |||
| - Shows display numbers at top right of each screen | |||
| - Removes previous monitor items if any were added | |||
| - Adds monitor items based on currently connected monitors | |||
| - sets monitor items based on currently connected monitors | |||
There was a problem hiding this comment.
Sorry, I think I know what you mean.. but I'm lost as to what "nit" means in this context. Would you mind explaining?
There was a problem hiding this comment.
means that I am nitpicking
There was a problem hiding this comment.
As in the PR is fine, but I am trying to fix tiny things.
Grazfather
approved these changes
Jan 9, 2025
|
Thanks for your contribution! |
and thank you for taking the time to review and look through things! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove-monitor-itemsandadd-monitor-itemsare always run in sequence to basically set the monitor items. Using a single function both simplifies the code, and also makes it more understandable.