fix: add HTTP client timeout to prevent webhook reports hanging forever #484
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,38 @@ | ||||||||||||||||
| package github | ||||||||||||||||
|
|
||||||||||||||||
| import ( | ||||||||||||||||
| "fmt" | ||||||||||||||||
|
|
||||||||||||||||
| gocache "github.com/patrickmn/go-cache" | ||||||||||||||||
| ) | ||||||||||||||||
|
|
||||||||||||||||
| func (c *Client) HasReleases(owner, repo string) (bool, error) { | ||||||||||||||||
| cacheKey := "releases:" + owner + "/" + repo | ||||||||||||||||
| if cached, found := c.cache.Get(cacheKey); found { | ||||||||||||||||
| return cached.(bool), nil | ||||||||||||||||
|
Comment on lines
+11
to
+12
Contributor
There was a problem hiding this comment. Unsafe type assertion can panic on cache corruption. The type assertion 🛡️ Proposed fix with safe type assertion- if cached, found := c.cache.Get(cacheKey); found {
- return cached.(bool), nil
+ if cached, found := c.cache.Get(cacheKey); found {
+ if boolVal, ok := cached.(bool); ok {
+ return boolVal, nil
+ }
}📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||
| } | ||||||||||||||||
|
|
||||||||||||||||
| v, err, _ := c.sf.Do(cacheKey, func() (interface{}, error) { | ||||||||||||||||
| if cached, found := c.cache.Get(cacheKey); found { | ||||||||||||||||
| return cached.(bool), nil | ||||||||||||||||
|
Comment on lines
+16
to
+17
Contributor
There was a problem hiding this comment. Unsafe type assertion can panic on cache corruption. The type assertion 🛡️ Proposed fix with safe type assertion if cached, found := c.cache.Get(cacheKey); found {
- return cached.(bool), nil
+ if boolVal, ok := cached.(bool); ok {
+ return boolVal, nil
+ }
}📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||
| } | ||||||||||||||||
|
|
||||||||||||||||
| url := fmt.Sprintf( | ||||||||||||||||
| "https://api.github.com/repos/%s/%s/releases?per_page=1&page=1", | ||||||||||||||||
| owner, repo, | ||||||||||||||||
| ) | ||||||||||||||||
|
|
||||||||||||||||
| var releases []struct{} | ||||||||||||||||
| if err := c.get(url, &releases); err != nil { | ||||||||||||||||
| return false, err | ||||||||||||||||
| } | ||||||||||||||||
|
|
||||||||||||||||
| hasReleases := len(releases) > 0 | ||||||||||||||||
| c.cache.Set(cacheKey, hasReleases, gocache.DefaultExpiration) | ||||||||||||||||
| return hasReleases, nil | ||||||||||||||||
| }) | ||||||||||||||||
| if err != nil { | ||||||||||||||||
| return false, err | ||||||||||||||||
| } | ||||||||||||||||
| return v.(bool), nil | ||||||||||||||||
|
Contributor
There was a problem hiding this comment. Unsafe type assertion can panic if the single-flight function returns unexpected type. Although the single-flight function should always return 🛡️ Proposed fix with safe type assertion- return v.(bool), nil
+ if boolVal, ok := v.(bool); ok {
+ return boolVal, nil
+ }
+ return false, fmt.Errorf("internal error: single-flight returned non-bool value")📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||
| } | ||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1058,7 +1058,11 @@ func (m MainModel) analyzeRepo(ctx context.Context, repoName string) tea.Cmd { | |
| // Stage 5: Compute metrics | ||
| score := analyzer.CalculateHealth(repo, commits) | ||
| busFactor, busRisk := analyzer.BusFactor(contributors) | ||
| hasReleases, hasRelErr := client.HasReleases(parts[0], parts[1]) | ||
| if hasRelErr != nil { | ||
| hasReleases = false | ||
| } | ||
| maturityScore, maturityLevel := analyzer.RepoMaturityScore(repo, len(commits), len(contributors), hasReleases) | ||
| contributorInsights := analyzer.AnalyzeContributors(contributors) | ||
|
|
||
| commitsLast90Days := 0 | ||
|
|
@@ -1426,7 +1430,8 @@ func (m MainModel) compareRepos(repo1Name, repo2Name string) tea.Cmd { | |
| fileTree1, _ := client.GetFileTree(parts1[0], parts1[1], repo1.DefaultBranch) | ||
| score1 := analyzer.CalculateHealth(repo1, commits1) | ||
| busFactor1, busRisk1 := analyzer.BusFactor(contributors1) | ||
| hasReleases1, _ := client.HasReleases(parts1[0], parts1[1]) | ||
| maturityScore1, maturityLevel1 := analyzer.RepoMaturityScore(repo1, len(commits1), len(contributors1), hasReleases1) | ||
|
|
||
| result1 := AnalysisResult{ | ||
| Repo: repo1, | ||
|
|
@@ -1452,7 +1457,8 @@ func (m MainModel) compareRepos(repo1Name, repo2Name string) tea.Cmd { | |
| fileTree2, _ := client.GetFileTree(parts2[0], parts2[1], repo2.DefaultBranch) | ||
| score2 := analyzer.CalculateHealth(repo2, commits2) | ||
| busFactor2, busRisk2 := analyzer.BusFactor(contributors2) | ||
| hasReleases2, _ := client.HasReleases(parts2[0], parts2[1]) | ||
| maturityScore2, maturityLevel2 := analyzer.RepoMaturityScore(repo2, len(commits2), len(contributors2), hasReleases2) | ||
|
|
||
| result2 := AnalysisResult{ | ||
| Repo: repo2, | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: agnivo988/Repo-lyzer
Length of output: 490
Add a LICENSE file to the repository root.
The badge on line 8 (
https://github.com/agnivo988/Repo-lyzer/blob/main/LICENSE) references a LICENSE file that does not exist in the repository. This breaks the license badge. Create a LICENSE file in the repository root and choose an appropriate open-source license for the project.The CI workflow badge on line 11 correctly references
.github/workflows/ci.yml, which exists in the repository.🤖 Prompt for AI Agents