Skip to content

Print line violations only under --verbose flag #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

ulysses4ever
Copy link
Contributor

@ulysses4ever ulysses4ever commented Mar 18, 2023

Alleviates #48 but a proper performance fix would be better. Also, --verbose already existed, so I reused it. Maybe, it's a bad idea, 'cause it will be impossible to find anything in a string of [ Checked ] (this is what --verbose currently means: it prints this for all non-violating files). But that's what was suggested in #48… Opinions?

Otherwise, I put back the old implementation beside the new one, mostly. Some common bits are factors out.

Time measurements

v0.0.11 release

❯ time $FW --check 20000-violations.txt 2> /dev/null

Executed in 36.48 millis

❯ time $FW --check 200000-violations.txt 2> /dev/null

Executed in 100.67 millis


master:

❯ time $FW --check 20000-violations.txt 2> /dev/null

Executed in 661.54 millis

❯ time $FW --check 200000-violations.txt 2> /dev/null

Executed in 6.13 secs


patch

❯ time $FW --check 20000-violations.txt 2> /dev/null

Executed in 35.82 millis

❯ time $FW --check 200000-violations.txt 2> /dev/null

Executed in 123.55 millis

❯ time $FW --check -v 20000-violations.txt 2> /dev/null

Executed in 718.26 millis

❯ time $FW --check -v 200000-violations.txt 2> /dev/null

Executed in 6.42 secs

@ulysses4ever
Copy link
Contributor Author

ulysses4ever commented Mar 18, 2023

Actually, I probably don't need a new constructor: it only adds noise.

@ulysses4ever ulysses4ever force-pushed the log-violations-under-verbose branch from beb220e to 8ddb508 Compare March 18, 2023 21:42
Alleviates agda#48 but a proper performance fix would be better.
@ulysses4ever ulysses4ever force-pushed the log-violations-under-verbose branch from 8ddb508 to ec5acdc Compare March 18, 2023 21:43
@ulysses4ever
Copy link
Contributor Author

Done.

@ulysses4ever
Copy link
Contributor Author

Hey @andreasabel! Do you think you could get back to this at some point? I totally understand if you have another priorities, of course.

@ulysses4ever
Copy link
Contributor Author

Ping.

@andreasabel andreasabel added this to the 0.1 milestone Aug 7, 2023
Copy link
Member

@andreasabel andreasabel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I am trying to release this now.

@andreasabel andreasabel merged commit 46be4d2 into agda:master Aug 7, 2023
@ulysses4ever ulysses4ever deleted the log-violations-under-verbose branch September 2, 2023 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants