-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a few algebraic structures missing from the Algebra.Construct.Pointwise #2555
Conversation
Bradley, thanks for mopping up the missing pieces of #2381 ! A nice first PR. NB we'll need a |
Thanks!
To be clear, you'd like me to add something like the following?
|
... Yup! It's boring but exactly what's required. |
Cool. Added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks good now!
Just needs a second approval.
This PR adds a few structures/bundles currently missing from
Algebra.Construct.Pointwise
, namely:isNearSemiring
isSemiringWithoutOne
isCommutativeSemiringWithoutOne
isCommutativeSemiring
isIdempotentSemiring
isKleeneAlgebra
isQuasiring
isCommutativeRing