-
Notifications
You must be signed in to change notification settings - Fork 247
a better scanr
, via Data.List.NonEmpty
#2258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 10 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
9aed9a7
a better `scanr`
jamesmckinna 370e69c
typo in deprecation warning
jamesmckinna 0ec35d0
fixed `Properties`
jamesmckinna d2ebaa1
moved things around, following @gallais's suggestion
jamesmckinna 61eddec
fixed knock-on errors
jamesmckinna 7a2cb57
removed `scanr⁺` completely
jamesmckinna 5e68d9e
final cosmetic tweaks
jamesmckinna 4503383
`module` parameters
jamesmckinna 239c34b
tidied up deprecated proof
jamesmckinna d0e41a7
redefined `scanr` in terms of `scanr⁺` etc.
jamesmckinna 5d1963e
missing `CHANGELOG` entry
jamesmckinna 827f530
fix `CHANGELOG`
jamesmckinna f782b3e
simplified and refactored proofs
jamesmckinna e16bf55
local definition, for readability
jamesmckinna 1099e69
Merge branch 'master' into scanr
jamesmckinna 4b77360
Merge branch 'master' into scanr
jamesmckinna a080693
Merge branch 'master' into scanr
jamesmckinna File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is screaming to me that we're doing something wrong here with the dependencies. Can we discuss this evening at the stdlib implementor's meeting?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, this is the motor for this PR: AFAICT, the
Data.List.Base
defn ofscanr
arises in the (historical) form it takes precisely to ensure that it can exist inData.List.Base
, without any of the other analysis of its typing.But, as other commenters elsewhere note, the 'official' library definition has terrible properties (or better: terrible proofs of its properties...) because of its 'wrinkly' definition, arising from its combination of
with
and dead-code.The other operations considered in #2267 / #2269 are OK, but
scanr
seems 'special'.This PR represents my attempt at the least-invasive restructuring of
Data.List.Base
able to avoid the wrinkles...