Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ fix #1743 ] move README to
doc/
directory #2184[ fix #1743 ] move README to
doc/
directory #2184Changes from 8 commits
00dc06c
7eaabc2
98843ee
8c055de
dd6cf79
ad47e19
04f3be1
561d924
ec1c00d
059c659
f7f8e5d
5f3f0b3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, I've been thinking a lot (if not 'hard') about this, and I don't know if it makes more, or less, sense, to have the
README.*
modules in adoc
directory, or in good-oldREADME
as a top-level directory, and simply bump all the modules names 'up' one level, by having what would then beREADME.agda
import fromAxiom
rather thanREADME.Axiom
etc.Alternatively, leave the entire existing
README/
directory alone, but simply have itsblah.agda-lib
point at... the right directories (and here is where I get confused about what those should be.... ../src
as already, or. ./README ../src
(I guess this latter is subsumed by the former?)In other words, the change could be less invasive still simply by moving toplevel
README.agda
toREADME/
, and updating theGNUmakefile
and.github/tooling
scripts?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many modules in
README
have identical paths as the modules from the standard library (e.g.README/Function/Reasoning.agda
andsrc/Function/Reasoning.agda
,README/Data/List.agda
andsrc/Data/List.agda
, etc.). If theREADME.
prefix in the module paths is removed, I wonder how Agda resolves the module?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think because the
include
directive line will ensure that those indoc/README
will get searched for before trying to look for them insrc
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
include
in this PR looks good to me. What I don't understand is how your alternative approach works. (this one:I might be wrong, but including
../README
directory before../src
ininclude:
sounds like modules inREADME
will shadow those that have the same name insrc
. Without theREADME.
prefix in the module paths, how could files likeREADME.Data.List.Relation.Binary.Equality
that importData.Nat
continue to work? Wouldn'tData.Nat
incorrectly refers toREADME.Data.Nat
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah... ok, perhaps you're right.
In any case, I would prefer simply to have the
doc
directory be calledREADME
instead. Or are you saying that such a solution also would not work?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that should work.