Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancement to
Relation.Nullary.Reflects
etc. #2149New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement to
Relation.Nullary.Reflects
etc. #2149Changes from 11 commits
a0db97c
ea024ec
9d92dd5
3c41be8
9df29e6
259e966
35bb709
a68ab46
8fba674
d8fe713
856d8d3
af83f0a
67f75a3
964b973
2410d81
1308e1d
507d3b1
7512da6
13f196a
edc184a
f5329db
d1ee514
40558fe
a9b8c24
66dbe56
3e174d6
9ec8399
ec880fb
8090a06
6d473aa
cb52c08
27234f7
13c3693
b6abf30
2a8b773
16776b5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So... this is claimed as a more strict version of
does
... even in the original version of this module. That suggests the following possible refactoring:Data.Bool.Base
addisYes = strictify ∘ does
Would that be preferable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I certainly find that idiom appealing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps that's worth considering for
data
generally, not justBool
?(I'm mostly think of
Nat
, but others perhaps also...)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, ought to consider strictification of various
data
. Too bad it doesn't seem like that idiom can be made generic (or, at least, my brain can't see how to do it, without meta-programming.)