-
Notifications
You must be signed in to change notification settings - Fork 65
Encode connection ID for the URL path #2605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We want this included at RC3. So, as I learned, this should be based on (and targeting to) the corresponding |
dgdavid
requested changes
Jul 24, 2025
As it was not marked as fastrack I was not sure. I will switch the branch |
dgdavid
approved these changes
Jul 24, 2025
133c776 to
aa44728
Compare
dgdavid
approved these changes
Jul 24, 2025
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Jul 31, 2025
https://build.opensuse.org/request/show/1295725 by user IGonzalezSosa + dimstar_suse - Introduce inst.auto_insecure and inst.script_insecure to disable SSL checks for inst.auto and inst.script (bsc#1246836). - Added "--insecure" option to "agama config load" and "agama config generate" commands (related to bsc#1246836) - Fix CLI connection update when using an special character in the connection ID (bsc#1246930, gh#agama-project/agama#2605). - Add support for an inst.script option that allows to run an arbitrary script (bsc#1246702, gh#agama-project/agama#2589).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The CLI needs to encode the connection Id in order to use it in the URL for adding or updating it.
Solution
Encode the connection id in order to use it in the URL path for adding or updating a connection
Testing
Example profile net.json