Skip to content

Conversation

@teclator
Copy link
Contributor

@teclator teclator commented Jul 23, 2025

Problem

The CLI needs to encode the connection Id in order to use it in the URL for adding or updating it.

Solution

Encode the connection id in order to use it in the URL path for adding or updating a connection

Testing

  • Tested manually
    Example profile net.json
suse@vikingo:~$ cat net.json 
{
  "product": {
    "id": "Tumbleweed"
  },
  "network": {
    "connections": [
      {
        "id": "Wired #1",
        "status": "up"
      }
    ]
  }
}

suse@vikingo:~$ agama config load < net.json 
✓ The profile is valid.

suse@vikingo:~$ agama config load < net.json 
✓ The profile is valid.

## REMOVED IRRELEVANT DATA
suse@vikingo:~$ agama config show 
{
  "network": {
    "connections": [
      {
        "id": "Wired #1",
        "method4": "auto",
        "method6": "auto",
        "ignoreAutoDns": false,
        "status": "up",
        "autoconnect": true,
        "persistent": true
      }
    ]
  }
}

@coveralls
Copy link

coveralls commented Jul 23, 2025

Coverage Status

coverage: 68.06%. remained the same
when pulling d467382 on encode_connection_id
into bbb2b7d on rc3.

@ancorgs
Copy link
Contributor

ancorgs commented Jul 23, 2025

We want this included at RC3. So, as I learned, this should be based on (and targeting to) the corresponding rc3 branch.

@teclator
Copy link
Contributor Author

We want this included at RC3. So, as I learned, this should be based on (and targeting to) the corresponding rc3 branch.

As it was not marked as fastrack I was not sure. I will switch the branch

@teclator teclator changed the base branch from master to rc3 July 24, 2025 12:14
@teclator teclator force-pushed the encode_connection_id branch from 133c776 to aa44728 Compare July 24, 2025 12:19
@teclator teclator merged commit bfa873a into rc3 Jul 24, 2025
10 checks passed
@teclator teclator deleted the encode_connection_id branch July 24, 2025 12:58
bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this pull request Jul 31, 2025
https://build.opensuse.org/request/show/1295725
by user IGonzalezSosa + dimstar_suse
- Introduce inst.auto_insecure and inst.script_insecure to disable
  SSL checks for inst.auto and inst.script (bsc#1246836).

- Added "--insecure" option to "agama config load" and
  "agama config generate" commands (related to bsc#1246836)

- Fix CLI connection update when using an special character in
  the connection ID (bsc#1246930, gh#agama-project/agama#2605).

- Add support for an inst.script option that allows to run an
  arbitrary script (bsc#1246702, gh#agama-project/agama#2589).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants