Skip to content

fix(audio): name CW sidetone JACK client "AetherSDR CW Sidetone" #3517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ozy311 wants to merge 2 commits into
base: main
Choose a base branch
from
+21 −0
Open

fix(audio): name CW sidetone JACK client "AetherSDR CW Sidetone" #3517

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
89af738
fix(audio): name CW sidetone JACK client "AetherSDR CW Sidetone"
Ozy311 Jun 6, 2026
4e2ad68
style(audio): log PaJack_SetClientName failures like sibling PA calls
Ozy311 Jun 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions src/core/CwSidetonePortAudioSink.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@
#include "LogManager.h"

#include <portaudio.h>
#if defined(Q_OS_LINUX) && __has_include(<pa_jack.h>)
# include <pa_jack.h> // PaJack_SetClientName — name the PipeWire/JACK node
#endif

#include <QString>

Expand Down Expand Up @@ -162,6 +165,24 @@ bool CwSidetonePortAudioSink::start(const QAudioDevice& device,
m_fallbackReason.clear();

if (!m_paInitialized) {
#if defined(Q_OS_LINUX) && __has_include(<pa_jack.h>)
// Name the PortAudio->JACK/PipeWire client so the CW sidetone shows
// as "AetherSDR CW Sidetone" in qpwgraph/JACK patchbays instead of
// the bare PortAudio default. Must precede Pa_Initialize, and pa_jack
// references (does not copy) the string -> static lifetime. CW sidetone
// is AetherSDR's only PortAudio user, so naming the process-global JACK
// client here is unambiguous.
static const char kJackClientName[] = "AetherSDR CW Sidetone";
// PaJack_SetClientName returns PaError; surface a failure like the
// Pa_Initialize path below. Non-fatal — the node keeps its default
// name — so log and continue rather than abort.
const PaError nameErr = PaJack_SetClientName(kJackClientName);
if (nameErr != paNoError) {
qCWarning(lcAudio) << "CwSidetonePortAudioSink: PaJack_SetClientName failed —"
<< Pa_GetErrorText(nameErr)
<< "(node keeps its default name)";
}
#endif
const PaError err = Pa_Initialize();
if (err != paNoError) {
qCWarning(lcAudio) << "CwSidetonePortAudioSink: Pa_Initialize failed —"
Expand Down
Loading