Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APPS-1369 Optimize restore to empty databases #308

Merged
merged 12 commits into from
Jan 19, 2025

Conversation

korotkov-aerospike
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 6.25000% with 75 lines in your changes missing coverage. Please review.

Project coverage is 43.94%. Comparing base (dfb0685) to head (73b7b16).

Files with missing lines Patch % Lines
pkg/service/aerospike/namespace_empty.go 0.00% 60 Missing ⚠️
pkg/service/restore_data.go 7.69% 10 Missing and 2 partials ⚠️
pkg/service/aerospike/namespace_validator.go 0.00% 2 Missing ⚠️
pkg/dto/current_backup.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               v3     #308      +/-   ##
==========================================
- Coverage   45.03%   43.94%   -1.09%     
==========================================
  Files          53       54       +1     
  Lines        2929     3006      +77     
==========================================
+ Hits         1319     1321       +2     
- Misses       1473     1546      +73     
- Partials      137      139       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@korotkov-aerospike
Copy link
Contributor Author

I've added finish time to restore job status to be able measure speed.
Testing of emptiness is incorporated into namespace validator, I don't want to create new struct.

@korotkov-aerospike korotkov-aerospike marked this pull request as ready for review January 16, 2025 12:08
pkg/dto/current_backup.go Outdated Show resolved Hide resolved
pkg/dto/restore_result.go Show resolved Hide resolved
pkg/service/aerospike/namespace_empty.go Outdated Show resolved Hide resolved
@reugn reugn changed the title APPS 1369 Optimize restore to empty database APPS-1369 Optimize restore to empty databases Jan 16, 2025
@korotkov-aerospike korotkov-aerospike merged commit a034f94 into v3 Jan 19, 2025
7 checks passed
@korotkov-aerospike korotkov-aerospike deleted the APPS-1369/ChangeRestoreOrder branch January 19, 2025 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants