-
Notifications
You must be signed in to change notification settings - Fork 38
Conversation
OVP showed us some problems with general user experience:
That is why I'm going to use this as a long-living branch to bring full features of graphback and measure impact on offix |
model/task.graphql
Outdated
} | ||
|
||
### Custom types used by model |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those are the examples of the Scalars we should have added out of the box.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeap.
@kingsleyzissou Quick opinion. Do we want to have TaskView screen that will allow add comments. I have done some preparation for this, |
@wtrocki, I think if it's not too much work and it's easy to maintain then we can go ahead with a |
@wtrocki the root query should be holding a reference to the normalised cache objects, is that correct? And here it just looks like it’s duplicating them in both places. Have I understood correctly? |
No DataSync yet
Requires: aerogear/offix#504
Requires custom offix: aerogear/offix#504 |
I have updated offix to make this work. @kingsleyzissou would you have time to play with this branch in context of the: Some things might require some quick fixes still (I do not have much time to get that done now) but it looks we can somehow patch offix to work with latest graphback and unblock release while still keeping the work on the datastore. Any feedback is greatly appreciated. What is outstanding here:
|
Okay leave the outstanding stuff, I will have a look at that and try get that sorted. Just busy testing the updates on the sample app and then I'll come around to this. |
import SimpleSchema from "simpl-schema"; | ||
|
||
// add the uniforms property to SimpleSchema | ||
SimpleSchema.extendOptions(['uniforms']); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wtrocki I created a config file for Simple Schema, so we can re-use this if we have other forms.
It wouldn't allow me to register the option globally in the router, so I went for this approach.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it!
I think it will be easier for us to merge this to master with alpha release after we know that keycloak works (@kingsleyzissou since you have been doing keycloak before can you try this with keycloak as well). If we merge then we can add incremental changes and proper graphback release once it happens. @kingsleyzissou Does this make sense? Ping me for quick review of the client once you are happy with this :D |
@wtrocki sure I will review the keycloak stuff. I will try find a quick win for the optimistic responses, I think the Offix 2.0 stuff should take priority. Will ping you as soon as it's ready |
@wtrocki I have updated those small changes. Doesn't look like the keycloak role stuff is working properly. But will try debug that on Monday morning. Have a good weekend. |
Merges are not conflicts itself they are considered an informational elements.
This is ready to be merged. However some clarification and verification of the walkthrough will be needed. CC @mmusil |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified:
- online CRUD working
- offline CRUD working
- Keycloak authorisation working
Purpose of this branch is to bring latest and greatest features from
Graphback and Offix.