Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for object texture updates after a dynamic sprite changes #5

Merged

Conversation

ivan-mogilko
Copy link
Contributor

Add tests to check if engine properly updates object's texture after dynamic sprite was changed or recreated.
There's an annoying bug that continuously resurfaces since we started optimizing textures.

The test makes screenshots and compares certain rectangle with an expected image of an object.
There's a caveat that test result will depend on a graphics driver.

@ivan-mogilko ivan-mogilko force-pushed the test--dynamicspriteupdate branch 2 times, most recently from ec090c9 to dc7d9db Compare April 2, 2024 22:12
@ivan-mogilko ivan-mogilko force-pushed the test--dynamicspriteupdate branch from dc7d9db to 25d5522 Compare April 2, 2024 22:43
@ericoporto
Copy link
Member

ericoporto commented Apr 2, 2024

Pretty cool, it's failing here on Direct3D and passing on the Software driver!

I can add an additional run here for the OpenGL driver too.

In the main repository we run the Software driver in Linux, OpenGL in macOS and Direct3D in Windows.

Btw, failures here are allowed, it's just the AGS pipeline that will show red on failure - and only the GitHub Actions there, it won't block a release. The idea is exactly this case of having an issue here writing a test that shows and fixing there later.

The AGS version ran here is whatever is set in the project in the Game.agf file. It will look for it in the GitHub Releases and install here to build the project and run it.

@ericoporto ericoporto merged commit d7ee3c6 into adventuregamestudio:main Apr 2, 2024
2 checks passed
@ericoporto
Copy link
Member

Replicated your test to the ags4 project and created a new release including it, it should run in the main repository on any next run, because there it just grabs the latest release - for now, later in the future I may switch that repository for tagged runs, at least in release branches.

@ivan-mogilko ivan-mogilko deleted the test--dynamicspriteupdate branch April 3, 2024 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants