-
Notifications
You must be signed in to change notification settings - Fork 2
Adapt to modified LGTM_
env variables behavior
#125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
LGTM_
behavior
LGTM_
behaviorLGTM_
env variables behavior
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mbaluda Thanks! It looks good overall. Question: why are files in log-injection-with-service1-protocol-none and log-injection-with-service2-protocol-none renamed?
@jeongsoolee09 Code Scanning running an updated version of the query will not open a new alert if the location does not change, but instead it will reuse the old one. To see the correct result (only one source in service1) I had to rename the test. An alternative could be to delete and recreate the configuration... |
@mbaluda I see, could you rename it back to the old name ( |
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you! Sometime we'll have to migrate from using these undocumented environment variables. 🤔
LGTM_INDEX_FILETYPES: ".json:JSON"
to includemodel.json
and*.cds.json
files in the DBsergeysova/jq-action
with a one-liner scriptjavascript.sarif.expected
file