Skip to content

Fix code-scanning workflow #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 28, 2024
Merged

Fix code-scanning workflow #122

merged 2 commits into from
May 28, 2024

Conversation

mbaluda
Copy link
Contributor

@mbaluda mbaluda commented May 28, 2024 •
edited
Loading

@mbaluda mbaluda requested a review from jeongsoolee09 May 28, 2024 22:53
@mbaluda mbaluda enabled auto-merge (squash) May 28, 2024 22:53
@mbaluda mbaluda self-assigned this May 28, 2024
@jeongsoolee09
Copy link
Contributor

Thank you @mbaluda! Could you explain why the Code Scanning job was failing, and how the changes made in this pull request fix it?

@mbaluda
Copy link
Contributor Author

mbaluda commented May 28, 2024

Thank you @mbaluda! Could you explain why the Code Scanning job was failing, and how the changes made in this pull request fix it?

In main there is no alert for code scanning.
This is because the DB created by the init action did not include any .js file due to a change in the behavior of LGTM_INDEX_FILTERS and paths configuration

jeongsoolee09
jeongsoolee09 approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@jeongsoolee09 jeongsoolee09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@mbaluda mbaluda merged commit fb70faa into main May 28, 2024
5 checks passed
@mbaluda mbaluda deleted the mbaluda-code-scanning branch May 28, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeongsoolee09 jeongsoolee09 jeongsoolee09 approved these changes

Assignees

@mbaluda mbaluda

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mbaluda @jeongsoolee09