-
-
Notifications
You must be signed in to change notification settings - Fork 16
Add dummy application #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add dummy application #5
Conversation
|
Just enabled CI for this repo, would you mind force pushing to trigger a new build? |
|
Also, the QP support you linked too looks like a good addition (I only have small tweaks/suggestions RE: the implementation). While digging into the failure here, I ran into the issue that #6 fixes (the test suite kept redirecting me 😡 ). |
e5a74b8 to
57d2a51
Compare
|
Adding support for query-params in #7 (I went a slightly different route from your implementation). There are still a few failing tests in this PR after that lands (around active state). |
57d2a51 to
3723d50
Compare
3723d50 to
7a7d408
Compare
|
Ok, just merged the QP support PR. How are we looking here? |
|
I've updated the acceptance test to be more strict for active classes on links with QP. e. g. if current URL is |
So I spent an afternoon creating this: https://github.com/martinmalinda/ember-router-helpers-2. But I was not thorough in checking if something like it exists.. and it does of course :).
So I thought I could at least port most of the missing logic here, starting with the dummy app.
The acceptance test completely fails here because there is no support for
(query-params)helper.I can provide support for those as well (https://github.com/MartinMalinda/ember-router-helpers-2/blob/master/addon/helpers/url-for.js#L5).
I have some other features there, such as empty
{{transition-to}}that can get the url fromevent. But I guess that that is a bit strange usecase?