fix(cloudflare): send named addresses as objects

src/transports/cloudflare.ts

@@ -52,14 +52,13 @@ class NodeMailerTransport implements Transport {
   }
 
   /**
-   * Formatting recipients to the "Name <email>" string format. Cloudflare
-   * accepts both plain strings and `{ email, name }` objects, but its docs
-   * are inconsistent on the object key (`email` vs `address`), so we use
-   * the universally accepted string representation.
+   * Formatting recipients for the Cloudflare API. A named recipient is sent
+   * as an `{ address, name }` object, since a plain string must be printable
+   * ASCII and "Name <email>" fails for names like "Équipe RH".
    */
   #formatRecipients(
     recipients?: MailMessage['data']['to'] | MailMessage['data']['cc'] | MailMessage['data']['bcc']
-  ): string[] {
+  ): (string | { address: string; name: string })[] {
     if (!recipients) {
       return []
     }
@@ -74,7 +73,7 @@ class NodeMailerTransport implements Transport {
       }
 
       if (recipient.name) {
-        return `${recipient.name} <${recipient.address}>`
+        return { address: recipient.address, name: recipient.name }
       }
 
       return recipient.address

tests/unit/transports/cloudflare.spec.ts

@@ -60,7 +60,7 @@ test.group('Cloudflare transport | payload', () => {
     assert.equal(headers.authorization, 'Bearer token')
   })
 
-  test('format recipients as "Name <email>" strings', async ({ assert }) => {
+  test('format named recipients as address objects', async ({ assert }) => {
     const { server, ready, payload } = captureServer(SUCCESS_RESPONSE)
     const baseUrl = await ready
 
@@ -75,11 +75,31 @@ test.group('Cloudflare transport | payload', () => {
     server.close()
 
     const body = await payload
-    assert.equal(body.from, 'Sender <sender@example.com>')
-    assert.deepEqual(body.to, ['Receiver <receiver@example.com>'])
+    assert.deepEqual(body.from, { address: 'sender@example.com', name: 'Sender' })
+    assert.deepEqual(body.to, [{ address: 'receiver@example.com', name: 'Receiver' }])
     assert.deepEqual(body.cc, ['cc@example.com'])
     assert.deepEqual(body.bcc, ['bcc@example.com'])
-    assert.equal(body.reply_to, 'Reply <reply@example.com>')
+    assert.deepEqual(body.reply_to, { address: 'reply@example.com', name: 'Reply' })
+  })
+
+  test('send names with non-ASCII characters', async ({ assert }) => {
+    const { server, ready, payload } = captureServer(SUCCESS_RESPONSE)
+    const baseUrl = await ready
+
+    const message = new Message()
+    message.from('noreply@example.com', 'Équipe RH')
+    message.to('receiver@example.com')
+    message.subject('Hello')
+    message.html('<p>Hello</p>')
+
+    await new CloudflareTransport({ key: 'token', baseUrl, accountId: 'acc' }).send(
+      message.toJSON().message
+    )
+    server.close()
+
+    const body = await payload
+    assert.deepEqual(body.from, { address: 'noreply@example.com', name: 'Équipe RH' })
+    assert.deepEqual(body.to, ['receiver@example.com'])
   })
 
   test('forward custom and list headers', async ({ assert }) => {