-
Notifications
You must be signed in to change notification settings - Fork 244
feat(tokens): expose renamed data for deprecated tokens
#6049
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
43 commits
Select commit
Hold shift + click to select a range
1ccd632
feat(typography): init 2nd-gen typography stylesheet generation
5t3ph 256b15e
feat(typography): adjust CJK font-size, margin multipliers, color, mo…
5t3ph 38bf4be
feat(*): update token related scripts, imports, README
5t3ph cfdedb7
feat(typography): init stories, preview styles
5t3ph 380f0ce
feat(typography): resolve sizes, improve custom properties, update ex…
5t3ph 6c75822
feat(typography): improve stories
5t3ph b29b845
feat(typography): improve maintainability, prose semantic element styles
5t3ph e666289
feat(typography): add title variant
5t3ph cd5561c
feat(typography): prevent size change for CJK code
5t3ph 299baa9
feat(typography): script cleanup
5t3ph 0344544
feat(typography): adjust heading styles, improve stories
5t3ph 3860946
Merge branch 'main' of https://github.com/adobe/spectrum-web-componen…
5t3ph df2fb59
chore(swc-tokens): update README
5t3ph 9324b82
fix(typography): stylelint-ignore generated file
5t3ph b29db7c
fix(*): address linting
5t3ph ec488c5
fix(*): lint order
5t3ph 95c1e77
fix(*): prettier
5t3ph 14d340e
fix(*): prettier
5t3ph a972f9d
feat(typography): story bg, heavy story, move logs to debug flag
5t3ph 98fc0bf
feat(storybook): hide Getting Started based on `utility` tag
5t3ph a19d44c
feat(typography): add missing heading XS, update swc-tokens README
5t3ph 255c3c9
Merge branch 'main' of https://github.com/adobe/spectrum-web-componen…
5t3ph 3745c33
fix(typography): lint format
5t3ph 1d8f305
fix(tokens): revert back to stylesheets dir
5t3ph b47680f
fix(*): revert eslint comment removal
5t3ph fabee5c
feat(tokens): integrate and expose `renamed` token data
5t3ph 0e260f1
Merge branch 'main' of https://github.com/adobe/spectrum-web-componen…
5t3ph 6ce6219
fix(typography): use double quotes
5t3ph 9ade16e
feat(tokens): extension perf/match improvements
5t3ph e320c03
Merge branch 'main' of https://github.com/adobe/spectrum-web-componen…
5t3ph d358726
fix(tokens): fix README merge conflict
5t3ph c8ddfd0
feat(tokens): exclude /tools/ from token diagnostics
5t3ph cdb90ad
fix(typography): reformat stylesheet
5t3ph ca42add
fix(typography): add missing `token` to string
5t3ph ffcdb67
fix(picker): flaky test
69be0dd
chore(docs): update customization > getting started
5t3ph 7d8632e
Merge branch 'main' into rajdeep/fix-picker-test
Rajdeepc 553f1ee
Merge branch 'rajdeep/fix-picker-test' into seckles/tokens-expose-ren…
da62e2a
fix(tokens): reuse data, not re-compute
5t3ph 59837bc
feat(tokens): add onDidClose to clear out sessions
5t3ph 6b2ab17
feat(tokens): optimize paths and cleanup diagnostic cache
5t3ph 8b2dca7
feat(tokens): update extension vsix
5t3ph 1b136ae
Merge branch 'main' of https://github.com/adobe/spectrum-web-componen…
5t3ph File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -33,7 +33,7 @@ | |
| }, | ||
| "displayName": "SWC token() Intellisense", | ||
| "engines": { | ||
| "vscode": "1.1.37" | ||
| "vscode": "^1.109.0" | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There were compat issues with a locked version, but this is entirely separate from our library since it is exclusive to the extension |
||
| }, | ||
| "homepage": "https://opensource.adobe.com/spectrum-web-components/", | ||
| "icon": "resources/icon.png", | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just updating to double-quotes