fix(combobox): align slotted field label with standalone label#6047
fix(combobox): align slotted field label with standalone label#6047aramos-adobe wants to merge 5 commits intonikkimk/form-field-mixinfrom
Conversation
|
📚 Branch Preview Links🔍 First Generation Visual Regression Test ResultsWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
Deployed to Azure Blob Storage: If the changes are expected, update the |



Description
Aligns the combobox slotted field label with standalone (typography, colors, sizes) and fixes picker button placement and disabled high-contrast styling.
This is also aims to align grid layout of the combobox referenced in SWC-1316
Motivation and context
The combobox uses FieldLabelMixin, which renders the label in shadow DOM. The slotted label’s CSS did not match the standalone
<sp-field-label>component, and the picker button could misalign when a label was present. Disabled state in forced-colors also needed to useGrayTextfor the picker button.Related issue(s)
Screenshots (if appropriate)
Still left TO-DO
.spectrum-PickerButton--quietdisabled stateAuthor's checklist
Reviewer's checklist
patch,minor, ormajorfeaturesManual review test cases
Slotted label vs standalone: Combobox default story and "With standalone field label" story — slotted label (e.g.
<span slot="field-label">) matches standalone<sp-field-label>in typography, spacing, and colors.Picker button alignment: Combobox with a slotted label — picker button stays aligned with the input row.
Forced-colors disabled: Disabled combobox in high-contrast mode — label and picker button use GrayText.
forced-colors: active" or Windows High Contrast).No regressions: Existing combobox stories (sizes, quiet, invalid, readonly, etc.) still look and behave correctly.
Device review