-
Notifications
You must be signed in to change notification settings - Fork 228
chore: update outdated spectrum CSS doc URLs #5575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
📚 Branch Preview🔍 Visual Regression Test ResultsWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
Deployed to Azure Blob Storage: If the changes are expected, update the |
Tachometer resultsCurrently, no packages are changed by this PR... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow! Did you manually update this?! This used to be auto-generated. 👩🍳 💋
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As @castastrophe mentioned, it seems like we did indeed previously have a script for this (see #1987) but I'm guessing we removed it during cutover because it referenced the config.js files that we removed at that time. That might be a nice thing to bring back and try to update at some point, but not necessarily here!
Otherwise just calling out a few formatting adjustments that need to be made and some components whose circumstances have changed a bit.
INVENTORY.md
Outdated
| meter | ✅ | | | | ||
| miller | | [📄](https://opensource.adobe.com/spectrum-css/?path=/docs/components-miller--docs) | ❌ | | ||
| millercolumn | ✅ | | | | ||
| modal | | [📄](https://opensource.adobe.com/spectrum-css/?path=/docs/components-modal--docs) | [📄](https://opensource.adobe.com/spectrum-web-components/components/modal) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, out of scope but the SWC link doesn't work 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm I dont seem to see a modal component at all in SWC. I went ahead and removed this.
2f5e5d9
to
f4b4ab7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found one more swc link that doesn't work, otherwise though this is good to go! Special thanks to Cursor for helping me validate every link!!
| tooltip | ✅ | [📄](https://opensource.adobe.com/spectrum-css/?path=/docs/components-tooltip--docs) | [📄](https://opensource.adobe.com/spectrum-web-components/components/tooltip) | | ||
| tray | ✅ | [📄](https://opensource.adobe.com/spectrum-css/?path=/docs/components-tray--docs) | [📄](https://opensource.adobe.com/spectrum-web-components/components/tray) | | ||
| treeview | ✅ | [📄](https://opensource.adobe.com/spectrum-css/?path=/docs/components-tree-view--docs) | ❌ | | ||
| typography | | [📄](https://opensource.adobe.com/spectrum-css/?path=/docs/components-typography--docs) | [📄](https://opensource.adobe.com/spectrum-web-components/components/styles) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This web components url doesn't work (https://opensource.adobe.com/spectrum-web-components/components/styles)
Description
Updated outdated Spectrum CSS doc URLs
Motivation and context
SWC-920
Previously, the Spectrum CSS team removed their standalone docs site in favor of using Storybook exclusively. This means that older documentation URLs (e.g.,
https://opensource.adobe.com/spectrum-css/typography.html) are now deprecated and should be replaced with the new Storybook-based format, such as:
or https://opensource.adobe.com/spectrum-css/?path=/docs/components-typography--docs
Author's checklist
Reviewer's checklist
patch
,minor
, ormajor
features