-
Notifications
You must be signed in to change notification settings - Fork 227
fix(styles): cjk alias mapping fixed #5529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: dd71f05 The changes in this PR will be included in the next version bump. This PR includes changesets to release 84 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Branch previewReview the following VRT differencesWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
If the changes are expected, update the |
Tachometer resultsCurrently, no packages are changed by this PR... |
36ae414
to
bf98e05
Compare
Is there any way we can test this via storybook? |
bf98e05
to
a2a135c
Compare
From my description:
It's pretty obvious looking at the code too that it's a simple fix. |
a2a135c
to
4f0f6d7
Compare
4f0f6d7
to
dd71f05
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for bringing this fix over! Send it!
Description
A contributor identified that one of our alias tokens for CJK font was pointing to the code font-family stack instead of the appropriate (and expected) CJK font-family stack.
Related issue(s)
Author's checklist
Reviewer's checklist
patch
,minor
, ormajor
featuresManual review test cases