Skip to content

ci, docs: Remove Spectrum CSS dependencies and processing #5472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
May 21, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
9102896
chore: remove spectrum-config.js files from various packages (#5417)
blunteshwar May 1, 2025
5990dfa
chore: update styling guide (#5437)
TarunAdobe May 9, 2025
5c8e834
chore: update grammer nits
TarunAdobe May 14, 2025
2af0867
chore: update docs grammer
TarunAdobe May 14, 2025
c6783a9
chore: remove unnecessary file generation during new-packge
TarunAdobe May 14, 2025
42430de
chore: remove spectrum-config from the generate-component doc
TarunAdobe May 14, 2025
f1be42c
chore: process-spectrum part 1 [swc-808]
castastrophe May 14, 2025
91dd37e
chore: include version alignment into constraints [swc-809]
castastrophe May 14, 2025
81fd690
chore: clean-up unused packages
castastrophe May 14, 2025
8370f01
chore: move tasks into scripts [swc-854] (#5476)
castastrophe May 15, 2025
a7c3009
chore: remove build-confirm command and fix cem-tools (#5482)
TarunAdobe May 19, 2025
1f93f5c
Merge branch 'main' into CSS-Cutoff
caseyisonit May 19, 2025
a3f7218
chore: addressing feedback
caseyisonit May 19, 2025
74199cb
chore: fix new-package command and more feedback
caseyisonit May 19, 2025
80082fd
chore: add back args and template plops
caseyisonit May 19, 2025
05f9dac
chore: spectrum config search feedback
caseyisonit May 19, 2025
7fb26b1
chore: addressing feedback
caseyisonit May 19, 2025
53c1fef
chore: addressing feedback
caseyisonit May 19, 2025
2c9b759
chore: addressing feedback
caseyisonit May 20, 2025
e7fa704
chore: addressing feedback
caseyisonit May 20, 2025
83079f5
chore: addressing feedback
caseyisonit May 20, 2025
7e1777b
chore: merge remote-tracking branch 'origin' into CSS-Cutoff
castastrophe May 21, 2025
d2a71c9
chore: update renovate config
caseyisonit May 21, 2025
9a36245
update capitalization
caseyisonit May 21, 2025
8644441
update copywright
caseyisonit May 21, 2025
3fa3ade
chore: update capitalization again
caseyisonit May 21, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -79,10 +79,16 @@
],
"overrides": [
{
"files": ["tasks/*", "scripts/*"],
"files": ["scripts/*"],
"rules": {
"no-console": ["off"]
}
},
{
"files": ["react/**/*.ts"],
"rules": {
"@typescript-eslint/no-explicit-any": "off"
}
}
]
}
6 changes: 1 addition & 5 deletions .github/CODEOWNERS
Original file line number Diff line number Diff line change
@@ -1,5 +1 @@
cem-react-wrapper.config.js @jianliao
scripts/cem-plugin-react-wrappers.js @jianliao
scripts/generate-icon-react-wrapper.js @jianliao
tasks/build-react.js @jianliao
* @adobe/swc-maintainers
* @adobe/swc-maintainers
2 changes: 1 addition & 1 deletion .github/renovate.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"labels": ["dependencies"],
"packageRules": [
{
"matchPackageNames": ["@spectrum-css/*"],
"matchFileNames": ["@*/*.css"],
"labels": ["Spectrum CSS"]
},
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,9 @@ OF ANY KIND, either express or implied. See the License for the specific languag
governing permissions and limitations under the License.
*/

import fg from 'fast-glob';
import fs from 'fs';

import fg from 'fast-glob';
import prettyBytes from 'pretty-bytes';

const getTachometerResults = () => {
Expand Down Expand Up @@ -156,7 +157,7 @@ export const buildTachometerComment = () => {
const firefoxTables = results.firefox.map(buildTable);
const chromeBody = chromeTables.length
? chromeTables.join(`

`)
: 'Currently, no packages are changed by this PR...';
const firefoxBody = firefoxTables.length
Expand Down
File renamed without changes.
4 changes: 2 additions & 2 deletions .github/workflows/browser-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ jobs:
uses: actions/github-script@v7
with:
script: |
const { buildTachometerComment } = await import('${{ github.workspace }}/tasks/build-tachometer-comment.js');
const { buildTachometerComment } = await import('${{ github.workspace }}/.github/scripts/build-tachometer-comment.js');
const { commentOrUpdate } = await import('${{ github.workspace }}/.github/scripts/comment-or-update.js');
const body = buildTachometerComment();
const { commentOrUpdate } = await import('${{ github.workspace }}/tasks/comment-or-update.js');
commentOrUpdate(github, context, '## Tachometer results', body);
1 change: 1 addition & 0 deletions .github/workflows/preview-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ jobs:
yarn constraints --fix
yarn version:update
yarn install --refresh-lockfile

- name: Configure NPM for changeset publish
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
Expand Down
5 changes: 2 additions & 3 deletions .github/workflows/urls-smoke-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,9 @@ jobs:
uses: actions/github-script@v7
with:
script: |
const { buildPreviewURLComment } = await import('${{ github.workspace }}/tasks/build-preview-urls-comment.js');
const { buildPreviewURLComment, getDocPreviewURL } = await import('${{ github.workspace }}/.github/scripts/build-preview-urls-comment.js');
const { commentOrUpdate } = await import('${{ github.workspace }}/.github/scripts/comment-or-update.js');
const body = buildPreviewURLComment(process.env.GITHUB_HEAD_REF);
const { getDocPreviewURL } = await import('${{ github.workspace }}/tasks/build-preview-urls-comment.js');
const { commentOrUpdate } = await import('${{ github.workspace }}/tasks/comment-or-update.js');
commentOrUpdate(github, context, '## Branch preview', body);

playwright-smoke-tests:
Expand Down
2 changes: 0 additions & 2 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ custom-elements.json
packages/*/src/**/*.css.js
packages/*/custom-elements.json
packages/**/*.js
packages/**/spectrum-vars.json
packages/**/*.js.map
packages/**/*.d.ts
packages/**/*.test-vrt.ts
Expand All @@ -50,7 +49,6 @@ projects/**/*.d.ts

tools/*/src/**/*.css.js
tools/*/custom-elements.json
tools/**/spectrum-vars.json
tools/**/*.js
tools/**/*.js.map
tools/**/*.d.ts
Expand Down
1 change: 0 additions & 1 deletion .vscode/settings.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
{
"files.exclude": {
"**/*.css.ts": { "when": "$(basename)" },
"packages/*/src/spectrum-vars.json": true,
"packages/**/*.js.map": true,
"packages/**/*.js": { "when": "$(basename).ts" },
"packages/**/*.dev.js": { "when": "$(basename).js" },
Expand Down
1 change: 0 additions & 1 deletion PULL_REQUESTS.md
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,6 @@ Incomplete templates may delay the review process.
- `breaking-change`: PR contains changes that break backward compatibility
- `help-wanted`: Extra attention is needed on this PR
- `on-hold`: PR needs more discussion.
- `Spectrum CSS`: An issue or pull request specific to the CSS being used by components.
- `Component: [Name]`: PR effects this component
- `auto-update`: Keep the base of the PR up-to-date with main automatically if there are no conflicts.

Expand Down
Loading
Loading